Skip to content

Setting version to 1.4.1 #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Setting version to 1.4.1 #284

merged 1 commit into from
Oct 17, 2019

Conversation

0xRoch
Copy link
Member

@0xRoch 0xRoch commented Oct 17, 2019

No description provided.

@0xRoch 0xRoch force-pushed the version-release-1-4-1 branch from a10fcf8 to 380cdd8 Compare October 17, 2019 12:42
@0xRoch 0xRoch force-pushed the version-release-1-4-1 branch from 380cdd8 to 1795a85 Compare October 17, 2019 12:42
@0xRoch 0xRoch merged commit 6c29fb1 into master Oct 17, 2019
@0xRoch 0xRoch deleted the version-release-1-4-1 branch October 17, 2019 12:56
@anilkumarmyla
Copy link

This is extremely puzzling, this commit is not available in master branch 👀 neither is the artifact published on maven central. Was the master branch reverted back?

@gslowikowski
Copy link
Member

@D-Roch what went wrong? You shouldn't change the version by hand. Versions are updated during release process.

@0xRoch
Copy link
Member Author

0xRoch commented Oct 23, 2019

@gslowikowski yes I reverted it sorry about that. Do you have time to do a sbt release ?

@maiflai
Copy link
Contributor

maiflai commented Oct 24, 2019

@gslowikowski - I normally publish the Gradle plugin to Sonatype under the org.scoverage group.

I could probably create a release build and publish it if you're too busy?

@gslowikowski
Copy link
Member

@maiflai I will try to release. Probably first existing 1.4.1 release and tag should be deleted.

@anilkumarmyla
Copy link

@gslowikowski @D-Roch fwiw, the revert of master branch was not done correctly, ideally I'd expect the commits in https://github.com/scoverage/scalac-scoverage-plugin/commits/6c29fb19b3ff042983de8d87a6ecb21557a7c854 match the commits in https://github.com/scoverage/scalac-scoverage-plugin/commits/master, but the top few don't

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants