fix parsing of exclusion options (introduced in 2872e73) #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Please could this be considered for a bug fix release? I think that exclusions are currently broken. Thanks, |
|
Exclusion options parsing was broken by this commit, part of #228. |
|
Thank you @maiflai |
|
Snapshot |
|
Looks good - thanks very much. Please would it be possible to look at my other (hopefully equally simple) PR #276 ? It would be great to get the Gradle plugin onto the current major version. Stu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently blocking me from upgrading the Gradle plugin to 1.4.
Is there any enthusiasm for refactoring the option parsing if I submit a separate PR?
Thanks,
Stu