JSDOMNodeJSEnv is handled incorrectly (Scalajs support issue)

[vpavkin]

When jsEnv is set to JSDOMNodeJSEnv().value, plugin treats it as PhantomJS environment.

This environment has a window property, so this conditional treats it as PhantomJS:
https://github.com/lustefaniak/scalac-scoverage-plugin/blob/master/scalac-scoverage-runtime/js/src/main/scala/scalajssupport/File.scala#L62

As a consequence - tests fail with:

scala.scalajs.js.JavaScriptException: TypeError: $g.callPhantom is not a function

The conditional should be tweaked somehow (no suggestions yet, so far just reporting).

---

Steps to reproduce:

1. Add to build.sbt jsEnv in Test := JSDOMNodeJSEnv().value
2. npm install jsdom
3. run tests

[vpavkin]

With 0.6.13 this becomes more real issue, because it affects default run configuration with RequiresDOM := true
https://www.scala-js.org/news/2016/10/17/announcing-scalajs-0.6.13/

[dzhagr]

Running into the same issue with scala.js 0.6.14. Looks like the PhantomJs is a fallback case during runtime interpreter resolution: https://github.com/scoverage/scalac-scoverage-plugin/blob/master/scalac-scoverage-runtime/js/src/main/scala/scalajssupport/File.scala#L62. Is there any better way to determine the runtime interpreter?

[dzhagr]

@vpavkin sorry, just noticed you are pointing to the same code line.

[tannerezell]

Is there a known workaround for this issue?

[nimaeskandary]

Has this been fixed/ has a workaround? Am trying to run scoverage and getting at endReadableNT (_stream_readable.js:1106:12) TypeError: $g.callPhantom is not a function