upgrade to scoverage 1.4

[maiflai]

• exclusion patterns appear to be broken upstream
• still investigating other breaks

[maiflai]

Dependencies:

• add a new aggregation method which is easily called from Groovy scalac-scoverage-plugin#276
• Release new version with working exclusion options scalac-scoverage-plugin#278

[eyalroth]

Should we add a (functional) test case for running with 1.3.1 with these changes to see they didn't break backward compatibility?

[maiflai]

Unfortunately they depend on a new function in 1.4 - do you think that's ok?

[eyalroth]

Yeah I can see that IOUtils.reportFileSearch has been replaced with IOUtils.scoverageDataDirsSearch, so there's actually no way to maintain backward compatibility.

That makes sense though; this plugin isn't really supposed to add any additional functionality and is just a "proxy" for the scalac plugin. In fact, defining a custom scalac plugin version (via scoverageVersion) should be experimental at best, much like it is with the maven plugin. Let's just update the README to clarify that :)

[maiflai]

Yes - I think it's possible to do things via reflection but it makes this more complicated than they need to be, given the scope of the plugin (as you say).

@gslowikowski - please would it be possible to get scoverage/scalac-scoverage-plugin#276 merged into a Snapshot so that we can test this?

Thanks,
Stu

[eyalroth]

@maiflai We should probably update the part in the README about the scoverageVersion option; we should note that (a) the default value has changed, (b) the plugin is compatible only with 1.4+ versions, and (c) it is experimental.

[maiflai]

yes, agree on (a) and (b) but not sure what you mean by (c)? it's new, but I wouldn't call it experimental.

I do think we should release this as a new major version of the Gradle plugin - as you pointed out before, the behaviour of the plugin has changed significantly. I'll add notes to the upgrading section.

[eyalroth]

It is experimental as it might not be compatible with future versions of the scalac plugin (as happened in this case). I guess it's not crucial to mention that, though :)