Support mini-css-extract-plugin #17
Conversation
| @@ -56,26 +56,85 @@ function replaceStringInAsset(asset, source, target) { | |||
| */ | |||
| function reHashChunk(chunk, assets, hashFn) { | |||
| const oldHash = chunk.renderedHash; | |||
| const oldChunkName = chunk.files[0]; | |||
| const fileIndex = chunk.files.findIndex(file => file.endsWith('.js')); | |||
There was a problem hiding this comment.
With mini-css active, .js files tend to end up in files[1].
| * This function updates the *name* of the main file (i.e. source code), and the *content* of the | ||
| * secondary files (i.e source maps) | ||
| */ | ||
| function reHashCssAsset(chunk, assets, hashFn) { |
There was a problem hiding this comment.
Lots of similar code to reHashChunk in here. Ideally, I'd be able to refactor this in a follow-up PR.
| const oldHash = chunk.contentHash[miniCssKey]; | ||
| const fileIndex = chunk.files.findIndex(asset => asset.match(oldHash)); | ||
| if (fileIndex === -1) { | ||
| throw new Error('Asset file not found for CssModule hash. Please use [contenthash] in MiniCssExtractPlugin placeholders.'); |
There was a problem hiding this comment.
If [contenthash] isn't used, runtime chunks end up with the same chunkhash in CSS / JS asset maps. This makes is impossible to reliably know which hash you're replacing. This could just replace the first instance it finds, and hope for the best ¯\(ツ)/¯
Having problems testing this 😕 Will update this PR if I figure it out.
|
Update: I've been looking at this PR and I can reproduce the problem. It is caused by my assumption that each chunk has one main file that need to be renamed + hashed, and many secondary files that only need to be rehashed. I'm working on a fix using @GoodForOneFare solution (basically merge the duplicated code), but before releasing it I would like to test it more with other plugins that might create extra "main" files. Hopefully it will happen in a couple of days. |
|
any updates on this PR? would love to implement this in our repo. |
|
@tomxhu still working on it. I have it working locally, I just need to clean it up a big and push it. Hopefully will happen today. |
|
Merged manually on master. |
What?
This rehashes
CssModuleobjects generated by mini-css-extract-plugin.Why?
extract-text-webpack-pluginwill not support webpack@4, and mini-css-extract-plugin is now the officially supported path for CSS.