-
Notifications
You must be signed in to change notification settings - Fork 45
Update documentation #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Roman Yurchak <[email protected]>
There are some changes here from #73 so we would need to merge that one first. But otherwise thanks a lot for improving the documentation, it really needs it. BTW, the way to avoid such issue with branchs is to always come back master, syncing with upstream and creating a branch from there for other PRs,
where upstream was defined as,
(or |
Ok thanks. Yes I was wondering what's up with all those commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @TimotheeMathieu ! It looks like a nice improvement.
The on case in test_kmedoid_results
failed but I see it also did on master. I think we need to fix the random state there.
Update of documentation
I changed the structure of the doc a bit so if you don't like it, tell me and I will make the changes.