Skip to content

YML file: CI Migration to Github Actions #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 16, 2021

Conversation

mvargas33
Copy link
Contributor

Resolves #325

Developed a draft YML file that handles the migration from Travis CI to Github actions.

  • Python 3.6, 3.7 and 3.8 are tested with sklearn=0.20.3 + skggm for compatibility. Python 3.9 doesn't work for some reason
  • Python 3.6, 3.7, 3.8 and 3.9 are tested with latest versions of dependencies, with and without skggm
  • Test reports are uploaded to Codecov, as before
  • Flake8 always run in the end
  • All tests run on the latest Ubuntu x64

Sorry for making too many commits, I could not find a way to debug this. But only one file is added and its automatically recognized by Guthub Actions.

This proposal is already working on my fork of metric_learning, at master branch.

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a couple of comments.

Copy link
Contributor

@perimosocordiae perimosocordiae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to merge this after resolving @terrytangyuan's comments

@mvargas33
Copy link
Contributor Author

All comments were resolved. All tests passed on my fork. File is ready to merge

@terrytangyuan terrytangyuan merged commit 5427159 into scikit-learn-contrib:master Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate CI to GitHub Actions
3 participants