Skip to content

[MRG] Correct a few small doc issues following #280 #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 4, 2020

Conversation

bellet
Copy link
Member

@bellet bellet commented Mar 4, 2020

This PR corrects a few minor problems with the doc that were left out of #280

Also added a temporary fix to a spacing issue due to a compatibility problem between rtd_theme and the new version of sphinx (see conf.py for details). This fix is used in other scikit-learn-contrib packages, such as imbalanced-learn

doc/conf.py Outdated
def setup(app):
app.add_javascript('js/copybutton.js')
app.add_stylesheet("basic.css")
# app.connect('autodoc-process-docstring', generate_example_rst)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this unnecessary line?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks!

@perimosocordiae perimosocordiae merged commit c378e4b into scikit-learn-contrib:master Mar 4, 2020
@perimosocordiae
Copy link
Contributor

LGTM, merged.

@bellet bellet deleted the pairs_docstring branch March 4, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants