Skip to content

[MRG] Add checks for labels when having pairs #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2019
Merged

[MRG] Add checks for labels when having pairs #197

merged 1 commit into from
May 3, 2019

Conversation

wdevazelhes
Copy link
Member

@wdevazelhes wdevazelhes commented Apr 29, 2019 •
edited
Loading

Fixes #164

@wdevazelhes wdevazelhes changed the title Add checks for labels when having pairs [WIP] Add checks for labels when having pairs Apr 29, 2019
@bellet
Copy link
Member

bellet commented Apr 30, 2019

LGTM

@wdevazelhes
Copy link
Member Author

I think we are good to merge

@wdevazelhes wdevazelhes changed the title [WIP] Add checks for labels when having pairs [MRG] Add checks for labels when having pairs May 2, 2019
@bellet bellet merged commit 8f57db2 into scikit-learn-contrib:master May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure labels for positive/negative pairs are as expected
2 participants
@wdevazelhes @bellet