Skip to content

Commit 2cf4075

Browse files
author
mvargas33
committed
Merge branch 'master' of https://github.com/scikit-learn-contrib/metric-learn into score-deprecation
2 parents 675dfcf + 8571f97 commit 2cf4075

File tree

4 files changed

+10
-202
lines changed

4 files changed

+10
-202
lines changed

.travis.yml

Lines changed: 0 additions & 65 deletions
This file was deleted.

README.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
|Travis-CI Build Status| |License| |PyPI version| |Code coverage|
1+
|GitHub Actions Build Status| |License| |PyPI version| |Code coverage|
22

33
metric-learn: Metric Learning in Python
44
=======================================
@@ -67,8 +67,8 @@ Bibtex entry::
6767

6868
.. _sphinx documentation: http://contrib.scikit-learn.org/metric-learn/
6969

70-
.. |Travis-CI Build Status| image:: https://api.travis-ci.org/scikit-learn-contrib/metric-learn.svg?branch=master
71-
:target: https://travis-ci.org/scikit-learn-contrib/metric-learn
70+
.. |GitHub Actions Build Status| image:: https://github.com/scikit-learn-contrib/metric-learn/workflows/CI/badge.svg
71+
:target: https://github.com/scikit-learn-contrib/metric-learn/actions?query=event%3Apush+branch%3Amaster
7272
.. |License| image:: http://img.shields.io/:license-mit-blue.svg?style=flat
7373
:target: http://badges.mit-license.org
7474
.. |PyPI version| image:: https://badge.fury.io/py/metric-learn.svg

build_tools/travis/flake8_diff.sh

Lines changed: 0 additions & 132 deletions
This file was deleted.

test/metric_learn_test.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,12 +79,17 @@ def test_singular_returns_pseudo_inverse(self):
7979
class TestSCML(object):
8080
@pytest.mark.parametrize('basis', ('lda', 'triplet_diffs'))
8181
def test_iris(self, basis):
82+
"""
83+
SCML applied to Iris dataset should give better results when
84+
computing class separation.
85+
"""
8286
X, y = load_iris(return_X_y=True)
87+
before = class_separation(X, y)
8388
scml = SCML_Supervised(basis=basis, n_basis=85, k_genuine=7, k_impostor=5,
8489
random_state=42)
8590
scml.fit(X, y)
86-
csep = class_separation(scml.transform(X), y)
87-
assert csep < 0.24
91+
after = class_separation(scml.transform(X), y)
92+
assert before > after + 0.03 # It's better by a margin of 0.03
8893

8994
def test_big_n_features(self):
9095
X, y = make_classification(n_samples=100, n_classes=3, n_features=60,

0 commit comments

Comments
 (0)