Skip to content

feat: get_requires_for_dynamic_metadata #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Conversation

henryiii
Copy link
Collaborator

Followup to #197. Supports hooks providing dynamic dependencies. This does not (officially, anyway, without inspecting the call stack) provide a method supporting differentiating between calling hooks.

@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #235 (031e5b2) into main (19b7782) will decrease coverage by 0.20%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
- Coverage   89.40%   89.21%   -0.20%     
==========================================
  Files          50       50              
  Lines        2134     2160      +26     
==========================================
+ Hits         1908     1927      +19     
- Misses        226      233       +7     
Impacted Files Coverage Δ
src/scikit_build_core/build/__init__.py 66.66% <0.00%> (-8.34%) ⬇️
src/scikit_build_core/setuptools/build_meta.py 58.33% <0.00%> (-13.10%) ⬇️
src/scikit_build_core/builder/get_requires.py 96.42% <100.00%> (+1.42%) ⬆️
...rc/scikit_build_core/metadata/fancy_pypi_readme.py 100.00% <100.00%> (ø)
src/scikit_build_core/metadata/setuptools_scm.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@henryiii henryiii merged commit 3017205 into main Mar 20, 2023
@henryiii henryiii deleted the henryiii/feat/get_req_meta branch March 20, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant