Skip to content

Update cancel_task to add clearUniqueId option #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2022

Conversation

artliou-scale
Copy link
Contributor

@artliou-scale artliou-scale commented Apr 28, 2022

  • Updated cancel_task and task.cancel() method with clear_unique_id option
  • Implemented delete_request (yay! for the first time in our API) and added DELETE to retry list
  • Implemented update_task_unique_id at API level and task.update_unique_id at task level
  • Implemented clear_task_unique_id at API level task.clear_unique_id as task level
  • Added two new test cases for test_update_unique_id and test_clear_unique_id
  • Updated README with new examples related to updates above ^

@fatihkurtoglu
Copy link
Contributor

CircleCI is probably failing due to code formatting. You can try running black to re-format your code based on the settings.

@artliou-scale artliou-scale force-pushed the feature/cancelTaskParameter branch 2 times, most recently from 312915d to 4e3f023 Compare April 28, 2022 21:10
@artliou-scale
Copy link
Contributor Author

CircleCI is probably failing due to code formatting. You can try running black to re-format your code based on the settings.

Am I missing something locally that Circle CI has?
Ran black [repo] and also ran the black --check -t py36 . the failing test is flagging.
Screen Shot 2022-04-28 at 2 14 03 PM

@fatihkurtoglu
Copy link
Contributor

I think you changed the formatting of other files too when you run that. can you double-check that?
Also we have some settings in SDK dev guide to set in VSCode, to make those things easier (in case your default formatter is different).
https://github.com/scaleapi/scaleapi-python-client/blob/master/docs/developer_guide.md#4-optional-vs-code-settings

@artliou-scale artliou-scale force-pushed the feature/cancelTaskParameter branch from 4e3f023 to b59920f Compare April 29, 2022 00:07
@artliou-scale artliou-scale reopened this Apr 29, 2022
@artliou-scale artliou-scale marked this pull request as ready for review April 29, 2022 00:21
Copy link
Contributor

@fatihkurtoglu fatihkurtoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm with few comments:

  • You need to bump version file version to deploy this as a new version (version later will be used by the release process)
  • Would be nice to add this new option in Readme file as an additional example under cancel task section.

@fatihkurtoglu
Copy link
Contributor

Submitted a new commit to include:

  • Updated .cancel() method on task object with clear_unique_id
  • Implemented delete_request (yay! for the first time in our API) and added DELETE to retry list
  • Implemented update_task_unique_id at API level and task.update_unique_id at task level
  • Implemented clear_task_unique_id at API level task.clear_unique_id as task level
  • Added two new test cases for test_update_unique_id and test_clear_unique_id
  • Updated README with new examples related to updates above ^

@fatihkurtoglu fatihkurtoglu merged commit 195b96a into master Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants