Add dataset.delete_scene #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfmark
reviewed
Jan 17, 2022
| @@ -738,6 +740,11 @@ def delete_item(self, reference_id: str) -> dict: | |||
| requests.delete, | |||
| ) | |||
|
|
|||
| @sanitize_string_args | |||
| def delete_scene(self, reference_id: str): | |||
There was a problem hiding this comment.
Wondering if it makes more sense to just have a delete_scenes(self, reference_ids: List[str]) method. We should also adapt the interface or at least add this method for the other data types to make it easier for the user and interate through the scenes internally rather then on the user side. Wdyt @gatli ?
There was a problem hiding this comment.
Can also do this in a second PR actually. So let's go ahead and merge once the endpoint is deployed.
There was a problem hiding this comment.
Agreed, that is probably a more natural interface. Let's add it to shortcut!
gatli
force-pushed
the
gunnar-delete-scene
branch
from
d4caa97 to
d4330ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Scene deletion through the SDK.
Still waiting for the endpoint to be deployed!