refactor uses of UPath #693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normanrz
commented
Apr 12, 2022
| if (path / "header.wkw").is_file(): | ||
| header_path = path / "header.wkw" | ||
|
|
||
| if header_path.exists() and header_path.is_file(): |
There was a problem hiding this comment.
This is a fix for a bug that @leowe found.
There was a problem hiding this comment.
One might argue that this is also a bug in UPath, but always sending two requests for the is_file check also seems wrong. In any case the fix is good atm!
There was a problem hiding this comment.
Yeah. I already have a fix for UPath in the pipeline.
normanrz
commented
Apr 12, 2022
| def make_upath(maybe_path: Union[str, PathLike, Path]) -> UPath: | ||
| return maybe_path if isinstance(maybe_path, UPath) else UPath(maybe_path) | ||
|
|
||
|
|
||
| def is_fs_path(path: Path) -> bool: |
There was a problem hiding this comment.
We could get rid of this as well, but I actually think is_fs_path is more expressive than not isinstance(path, UPath).
|
@normanrz Is this PR ready for review? |
Yes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that fsspec/universal_pathlib#56, fsspec/universal_pathlib#53 and fsspec/universal_pathlib#52 are merged, we can simplify our code a bit.