Add missing keywords from Dotty 0.17.0-RC1 #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
reviewed
Jul 27, 2019
There was a problem hiding this comment.
derives is still missing.
I wonder if there is a way to handle soft keywords. In Dotty these are
as derives inline opaque
inline and opaque are reserved only in modifier positions. as is reserved only in given instance definitions. derives is reserved only at places where extends would also be valid.
But we can also just tag them always as keywords.
|
Now those keywords are soft, the result is |
|
Looks right to me!
On Sat, 27 Jul 2019 at 20:08, Nicolas Stucki ***@***.***> wrote:
Now those keywords are soft, the result is
[image: Screenshot 2019-07-27 at 20 06 30]
<https://user-images.githubusercontent.com/3648029/61998037-3adcf980-b0aa-11e9-90c0-618291ffefc5.png>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#43?email_source=notifications&email_token=AAGCKVSX3HCL7S5QC6YDEL3QBSFLNA5CNFSM4IHJLNK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD26QCZQ#issuecomment-515703142>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGCKVTWMHLTIFXKVOBJ5BTQBSFLNANCNFSM4IHJLNKQ>
.
--
Martin Odersky
EPFL and Lightbend
|
|
@PanAeon could you have a look at this PR? |
PanAeon
approved these changes
Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.