Fix #9801: Make sure the errors are reported #9813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
commented
Sep 17, 2020
| @@ -0,0 +1 @@ | |||
| def test: Unit = loop(4) // error | |||
There was a problem hiding this comment.
Now, this reports correctly the NPE
-- Error: tests/pos-macros/i9801/Test_2.scala:1:21 ---------------------------------------------------------------------
1 |def test: Unit = loop(4)
| ^^^^^^^
| Exception occurred while executing macro expansion.
| java.lang.NullPointerException
| at dotty.tools.dotc.reporting.Message.dropNonSensical(Message.scala:65)
| at dotty.tools.dotc.reporting.Message.message(Message.scala:78)
| at dotty.tools.dotc.reporting.Message.isNonSensical(Message.scala:90)
| at dotty.tools.dotc.reporting.HideNonSensicalMessages.isHidden(HideNonSensicalMessages.scala:16)
| at dotty.tools.dotc.reporting.HideNonSensicalMessages.isHidden$(HideNonSensicalMessages.scala:10)
| at dotty.tools.dotc.reporting.TestReporter.isHidden(TestReporter.scala:18)
| at dotty.tools.dotc.reporting.Reporter.report(Reporter.scala:148)
| at dotty.tools.dotc.report$.error(report.scala:71)
| at dotty.tools.dotc.quoted.reflect.ReflectionCompilerInterface.error(ReflectionCompilerInterface.scala:90)
| at dotty.tools.dotc.quoted.QuoteContextImpl$$anon$1.error(QuoteContextImpl.scala:42)
| at Macro_1$package$.impl(Macro_1.scala:18)
|
| This location contains code that was inlined from Test_2.scala:2
inlined at Test_2.scala:1:There was a problem hiding this comment.
Notice that in this particular case the user passed a null into the reporting which made the reporting itself fail.
There was a problem hiding this comment.
You mean e.getMessage returns null?
nicolasstucki
force-pushed
the
fix-#9801
branch
from
6993e32 to
24a187e
Compare
nicolasstucki
force-pushed
the
fix-#9801
branch
from
24a187e to
ccf6c2a
Compare
liufengyun
approved these changes
Sep 17, 2020
| @@ -0,0 +1 @@ | |||
| def test: Unit = loop(4) // error | |||
There was a problem hiding this comment.
You mean e.getMessage returns null?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.