Add typeRef and termRef to Reflection #9707
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
add-typeRef-and-termRef
branch
from
50e4533 to
ca98cff
Compare
liufengyun
reviewed
Sep 3, 2020
| def Symbol_typeRef(self: Symbol)(using Context): TypeRef | ||
|
|
||
| /** Term referene to the symbol */ | ||
| def Symbol_termRef(self: Symbol)(using Context): TermRef |
There was a problem hiding this comment.
The two methods are rarely used in the compiler. I'd suggest only expose them when there is a clear use case.
liufengyun
reviewed
Sep 3, 2020
| val qtp: quoted.Type[T] = tp0.seal.asInstanceOf[quoted.Type[T]] | ||
| given qtp.type = qtp | ||
| '[Seq[T]].unseal.tpe | ||
| Symbol.requiredClass("scala.collection.immutable.Seq").typeRef.appliedTo(tp0) |
There was a problem hiding this comment.
It seems for this typical usage, an API like def fromPath(path: String): Type is more friendly:
Type.fromPath("scala.collection.immutable.Seq").appliedTo(tp0)
// or
Type.staticRef("scala.collection.immutable.Seq").appliedTo(tp0)The compiler API can keep the same, the user API can be a little different. This way, we also defend against compiler changes from meta-programmers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.