Skip to content

Some smaller tweaks #9658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 28, 2020
Merged

Some smaller tweaks #9658

merged 5 commits into from
Aug 28, 2020

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Aug 27, 2020

No description provided.

Cache empty type bounds and wildcard types over empty type bounds
in separate variables. This removes some of the load on uniques hashing
and avoid creation of temporary objects.
Without function specialization we got some boxing of Addr arguments.
Use a single traversal and a todo list instead of multiple traversals
This was used only when we also handled untyped trees during pickling.
@liufengyun
Copy link
Contributor

test performance please

@dottybot
Copy link
Member

performance test scheduled: 1 job(s) in queue, 0 running.

Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dottybot
Copy link
Member

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/9658/ to see the changes.

Benchmarks is based on merging with master (733b57c)

@odersky odersky merged commit 4c99388 into scala:master Aug 28, 2020
@odersky odersky deleted the opt-tweaks branch August 28, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants