Fix #9517: Do not print contents of ErrorType on -Xprint-types #9527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm but seeing which error was assigned where could be useful. Why does it lead to an infinite compilation? |
nicolasstucki
force-pushed
the
fix-#9517
branch
from
86f9ca1 to
d253777
Compare
nicolasstucki
force-pushed
the
fix-#9517
branch
from
d253777 to
cf38826
Compare
nicolasstucki
commented
Aug 11, 2020
| @@ -177,6 +177,8 @@ class PlainPrinter(_ctx: Context) extends Printer { | |||
| keywordStr(" match ") ~ "{" ~ casesText ~ "}" ~ | |||
| (" <: " ~ toText(bound) provided !bound.isAny) | |||
| }.close | |||
| case tp: PreviousErrorType if ctx.settings.XprintTypes.value => | |||
| "<error>" // do not print previously reported error message because they may try to print this error type again recuresevely | |||
| case tp: ErrorType => | |||
| s"<error ${tp.msg.rawMessage}>" | |||
There was a problem hiding this comment.
The infinite recursion happens here. The message may print a tree that contains this error type again.
There was a problem hiding this comment.
PlainPrinter already has some logic to avoid infinite loops with limiter and maxToTextRecursions, it'd be good to see if we can extend that to also account for the loops here
odersky
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.