Fix #9339: Register doc of extension methods #9375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
requested review from
abgruszecki
and removed request for
anatoliykmetyuk
abgruszecki
reviewed
Jul 16, 2020
| ctx | ||
| case _ => | ||
| ctx | ||
| } | ||
| recur(expanded(origStat)) | ||
| recur(expanded(origStat), 0) |
There was a problem hiding this comment.
This idx parameter looks really ugly and kludgy. Can't we instead add an origin parameter to recur which is usually the same as origStat but in the Thicket-ExtMethods case it's the appropriate element of t.methods?
There was a problem hiding this comment.
I changed it.
There was a problem hiding this comment.
That did not work, but I found a much simpler solution
abgruszecki
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.