Drop PreName and its associated implicit conversions #9273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
force-pushed
the
drop-conversions-1
branch
from
996a72d to
8bf9633
Compare
odersky
force-pushed
the
drop-conversions-1
branch
from
8bf9633 to
3abe2f0
Compare
That was not so hard. We can make PreName a union type and add `toTermName` and `toTypeName` as extension methods on strings.
odersky
force-pushed
the
drop-conversions-1
branch
from
3abe2f0 to
d998c65
Compare
odersky
force-pushed
the
drop-conversions-1
branch
from
d998c65 to
b21c1e4
Compare
This comment has been minimized.
This comment has been minimized.
nicolasstucki
approved these changes
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That was not so hard. We can make PreName a union type and
add
toTermNameandtoTypeNameas extension methods on strings.