Skip to content

Fix #9155: Propagate annotations on export forwarders #9156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 11, 2020
Merged

Fix #9155: Propagate annotations on export forwarders #9156

merged 2 commits into from
Jun 11, 2020

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki self-assigned this Jun 11, 2020
@nicolasstucki nicolasstucki linked an issue Jun 11, 2020 that may be closed by this pull request
Export does not export @alpha name #9155
Closed
@sjrd
Copy link
Member

sjrd commented Jun 11, 2020 •
edited
Loading

What about other annotations? @inline, @noinline, @deprecated, @varargs, @org.junit.Test? This continues. There is no one-size-fits-all answer, but when emitting bridges, I believe all annotations are copied, so we should probably do the same here.

@nicolasstucki nicolasstucki changed the title Fix #9155: Propagate @alpha on export forwarders Fix #9155: Propagate annotations on export forwarders Jun 11, 2020
@nicolasstucki nicolasstucki marked this pull request as ready for review June 11, 2020 14:56
@nicolasstucki nicolasstucki requested a review from smarter June 11, 2020 14:56
@smarter smarter merged commit eb34c6c into scala:master Jun 11, 2020
@smarter smarter deleted the fix-#9155 branch June 11, 2020 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarter smarter smarter approved these changes

Assignees

@smarter smarter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export does not export @alpha name
3 participants
@nicolasstucki @sjrd @smarter