fix resoruce leaks in tests and REPL, fixes #8358 #9036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
May 25, 2020
smarter
requested changes
May 25, 2020
| s"""Each file has to start with the prompt: "$prompt"""") | ||
|
|
||
| def extractInputs(prompt: String): List[String] = { | ||
| def extractInputs(lines: BufferedIterator[String]): List[String] = { |
There was a problem hiding this comment.
Could this use a plain collection like a Seq instead of an Iterator? I find iterators way too easy to misuse (e.g., if I try to print their content, then I break any code afterward), and this code isn't performance critical.
There was a problem hiding this comment.
Sure, I'll improve this 👍
smarter
approved these changes
May 25, 2020
|
@smarter this is ready to merge I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.