Obtain an immutable array from a mutable one #8826
Conversation
library/src/scala/IArray.scala
Outdated
| @@ -268,6 +268,9 @@ object IArray { | |||
| // A convenience to avoid having to cast everything by hand | |||
| private given [A] as Conversion[Array[A], IArray[A]] = identity[Sub[A]] | |||
|
|
|||
| /** Obtain an immutable array from a mutable one. */ | |||
| def apply[T](s: Array[T]): IArray[T] = s | |||
There was a problem hiding this comment.
This is unsafe, so it should be called something like unsafeFromArray
library/src/scala/IArray.scala
Outdated
| @@ -268,6 +268,9 @@ object IArray { | |||
| // A convenience to avoid having to cast everything by hand | |||
| private given [A] as Conversion[Array[A], IArray[A]] = identity[Sub[A]] | |||
|
|
|||
| /** Obtain an immutable array from a mutable one. */ | |||
There was a problem hiding this comment.
| /** Obtain an immutable array from a mutable one. */ | |
| /** Convert an array into an immutable array without copying, the original array | |
| * must _not_ be mutated after this or the guaranteed immutablity of IArray will | |
| * be violated. | |
| */ |
|
I don't think we should have this at all. We don't have |
|
But we do have |
|
|
|
Java never encodes immutability in the type system, so |
No description provided.