Fix #8758: strengthen the precondition for comparing extractors #8789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extractor `StringContext#s.unapplySeq` may have different prefix, thus we may not assume they are the same.
nicolasstucki
approved these changes
Apr 24, 2020
smarter
reviewed
Apr 24, 2020
Comment on lines
+82
to
+86
| /** Whether we may assume the two Unapply the same? | ||
| * That is, given the same parameter, returns the same result. | ||
| * | ||
| * This is more general than purity, as the same `unapply` method may | ||
| * take different prefix, thus behaves differently. |
There was a problem hiding this comment.
I was a bit confused by this description, here's a proposed slightly different version:
Suggested change
| /** Whether we may assume the two Unapply the same? | |
| * That is, given the same parameter, returns the same result. | |
| * | |
| * This is more general than purity, as the same `unapply` method may | |
| * take different prefix, thus behaves differently. | |
| /** True if we can assume that the two unapply methods are the same. | |
| * That is, given the same parameter, they return the same result. | |
| * | |
| * We assume that unapply methods are pure, but the same method may | |
| * be called with different prefixes, thus behaving differently. | |
| */ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8758: strengthen the precondition for comparing extractors
The extractor
StringContext#s.unapplySeqmay have different prefix,thus we may not assume they are the same.