Fix #8763: Limit number of import suggestions #8773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limit number of import suggestions and make computing the top-ranked suggestions more efficient.
nerush
reviewed
Apr 22, 2020
|
|
||
| /** The best `n` references in `refs`, according to `compare` | ||
| * `compare` is a partial order. If there's a tie, we take elements | ||
| * in the order thy appear in the list. |
There was a problem hiding this comment.
One small typo: thy should probably be they.
odersky
added
the
fasttrack
|
Since it fixes a potential very long compilation, it would be good to have this in 0.24 |
julienrf
approved these changes
Apr 23, 2020
smarter
requested changes
Apr 23, 2020
| var i = 0 | ||
| var diff = 0 | ||
| while i < filled && diff == 0 do | ||
| diff = compare(ref, top(i))(using ctx.retractMode(Mode.ImplicitsEnabled)) |
There was a problem hiding this comment.
Store ctx.retractMode(Mode.ImplicitsEnabled) in a val to avoid recomputing it at every iteration
There was a problem hiding this comment.
@smarter could you apply this fix directly, as per fasttrack label policy?
We don't have any benchmark infrastructure for code that contains compilation errors, so no way to benchmark this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit number of import suggestions and make computing the
top-ranked suggestions more efficient.