Make sure that QuoteContext are stable #8492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the internal encoding of the splices we assume that these are stable and use them for some path-dependent types. If they are not stable, some of the internal inferred types become less precise.
liufengyun
approved these changes
Mar 10, 2020
| @@ -12,12 +12,14 @@ class Foo { | |||
| } | |||
|
|
|||
| inline def i(): Unit = ${ Foo.impl[Any]('{ | |||
| given QuoteContext = ??? | |||
| val x: QuoteContext = ??? | |||
| given x.type = x | |||
There was a problem hiding this comment.
/cc @odersky : this seems to be a friction between given and path-dependent types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the internal encoding of the splices we assume that these are stable and use them for some path-dependent types. If they are not stable, some of the internal inferred types become less precise.