Skip to content

Fix #8214 Don't consume whitespace after XML #8228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2020
Merged

Fix #8214 Don't consume whitespace after XML #8228

merged 1 commit into from
Feb 7, 2020

Conversation

som-snytt
Copy link
Contributor

Forward port of scala/scala#4185

dottybot
dottybot reviewed Feb 6, 2020
View reviewed changes
Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

@som-snytt
Copy link
Contributor Author

A more natural test would just print trees or assert something about trees, but I haven't worked through the test infrastructure yet.

@odersky odersky merged commit 750ce40 into scala:master Feb 7, 2020
@som-snytt som-snytt deleted the issue/8214 branch February 7, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dottybot dottybot dottybot left review comments

@smarter smarter smarter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@som-snytt @smarter @dottybot @odersky