Generalize TypeBoundsTree to bounded opaque aliases #8212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
force-pushed
the
drop-withbounds
branch
from
26bc5f5 to
fd54330
Compare
The RHS of an opaque type can consist of three parts: ``` >: loBound <: hiBound = alias ``` This is encoded sp far in WithBounds annotation, but that mechanism means hidden complexity for the Tasty standard. We now encode the alias directly, as an optional third argument to a TypeBoundsTree structure.
Use new three-element TypeBoundsTree to represent bounded opaque aliases instead.
odersky
force-pushed
the
drop-withbounds
branch
from
fd54330 to
3e7d5af
Compare
|
@nicolasstucki Can you do the Tasty reflect side of this? As a separate PR is fine. |
smarter
approved these changes
Feb 6, 2020
12 tasks
|
This looks like a good change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RHS of an opaque type can consist of three parts:
This is encoded so far in a
WithBoundsannotation, but that mechanism meanshidden complexity for the Tasty standard. We now encode the alias directly,
as an optional third argument to a TypeBoundsTree structure.
Note: This needs an update of Tasty reader and Tasty reflection.