Allow MiniPhase to be DenotTransformer & LazyVals #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes naming uniform between trees and types, and also avoids the clash with transform.TreeTransformer. The idea is that transformers are parts of phases, and have logic that is phase-specific. In particular, a context is passed around when transforming a tree. Maps are simpler, they only have a T -> T apply method.
To bring in line with TreeTransformer terminology.
Many small and large changes. Added samplePhase to demonstrate functionality.
To test functioning, run the compiler with args
tests/pos/uncurry.scala -Ylog:sample,terminal
CreateCompanionObjectTests were re-enabled. They failed in a previous version but succeed again in the latest commit. Also uncurry.scala got renamed to curried.scala.
| @@ -61,7 +61,7 @@ class tests extends CompilerTest { | |||
| @Test def dotc = compileDir(dotcDir + "tools/dotc", twice) | |||
| @Test def dotc_ast = compileDir(dotcDir + "tools/dotc/ast", twice) | |||
| @Test def dotc_config = compileDir(dotcDir + "tools/dotc/config", twice) | |||
| @Test def dotc_core = compileDir(dotcDir + "tools/dotc/core", twice) | |||
| @Test def dotc_core = compileDir(dotcDir + "tools/dotc/core", twice, xerrors = 1) | |||
There was a problem hiding this comment.
ping @odersky
the line that breaks is https://github.com/DarkDimius/dotty/blob/integration/lazy/src/dotty/tools/dotc/core/Phases.scala#L117
There was a problem hiding this comment.
error: _id is not a member of T?
block._id = trans.head._id
There was a problem hiding this comment.
Changing to public accessor doesn't help:
See here: https://travis-ci.org/lampepfl/dotty/builds/21027367#L2878 , line 2878
Creates accessors for lazy vals: 1) lazy local vals are rewritten to dotty.runtime.Lazy*** holders 2) for a non-volatile field lazy val create a non-thread-safe accessor and flag: 2.a) if lazy val type indicates that val is not nullable, uses null value as a flag 2.b) else uses boolean flag for sake of performance, method size, and allowing more jvm optimizations 3) for a volatile field lazy val use double locking scheme, that guaranties no spurious deadlocks, using long bits as bitmaps and creating companion objects to store offsets needed for unsafe methods. Conflicts: test/dotc/tests.scala
|
I believe the commit message of the last commit is outdated. |
|
OK that's all for me ;-) Only minor things except for the commit message. |
All MiniPhases now as are full-fledged phases, and are given their own periods and can register DenotTransformers. MiniPhases belonging to same group(list) will be squashed to single phase.
|
I've updated the commit message. |
|
LGTM now. Thanks for the fixups! |
odersky
added a commit
that referenced
this pull request
Mar 20, 2014
Allow MiniPhase to be DenotTransformer & LazyVals
Closed
WojciechMazur
pushed a commit
to WojciechMazur/dotty
that referenced
this pull request
Mar 19, 2025
Backport "Make sure definition tree has the defined symbol" to 3.3 LTS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally :-)
@odersky, @sjrd please review