Fix #7959: Don't check Java symbols for private leaks #7994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java does not have the same rules as Scala here. Also, there are problems with package[private] which is translated to private[pkg]. In the test case, the constructor is assumed to be visible up to the package (because it is always annotated as such) which is further than the enclosing private class.
nicolasstucki
approved these changes
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java does not have the same rules as Scala here. Also, there are problems
with package[private] which is translated to private[pkg]. In the test case,
the constructor is assumed to be visible up to the package (because it
is always annotated as such) which is further than the enclosing private class.