Fix #7852: avoid reading stale .tasty files from jars #7918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somehow, if we don't close the classloader used to read .tasty files from jars, a subsequent compilation run might end up reading a stale version of the .tasty file which does not exist on disk anymore. I don't understand why this happens since we don't reuse the classloader itself, but that's life sometimes ¯\_(ツ)_/¯
nicolasstucki
approved these changes
Jan 7, 2020
compiler/src/dotty/tools/dotc/core/classfile/ClassfileParser.scala
Outdated
Show resolved
Hide resolved
The previous commit tried to fix some weird caching behaviors by closing the classloader used to read a .tasty file, but it turns out the JVM is dumb and that breaks any other in-use classloader that uses the same jar. Give up on the whole thing and work directly with the underlying ZipArchive to find the .tasty file (this just required adding a "parent" field to ZipArchive#Entry).
|
I had to use a different approach, see latest commit |
nicolasstucki
approved these changes
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.