Add requiredXYZ symbols to TASTy reflect context #7903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
approved these changes
Jan 7, 2020
| def Context_requiredClass(self: Context)(path: String): Symbol | ||
|
|
||
| /** Get module symbol if module is either defined in current compilation run or present on classpath. */ | ||
| def Context_requiredModule(self: Context)(path: String): Symbol |
There was a problem hiding this comment.
The meta-programmer may not know what's a module. Maybe rename to requiredObject?
There was a problem hiding this comment.
Better to keep names consistent. It will be simpler for documentation. We also have moduleClass and companionModule that use the same naming scheme.
There was a problem hiding this comment.
I totally agree, for advanced meta-programming, keeping the concepts closer to the compiler will help both meta-programmers who want to get into the compiler and maintenance of the framework.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.