Fix "did you mean" hinting #7895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Handle all members instead of just decls. - Simplify the logic and implementation. To tell the truth, the previous implementation was too convoluted for me to be able to say what it does exactly. But the new one seems to fit the intuitive spec.
The previous algorithm was simply wrong, which went undiscovered because there were no tests to its correctness. Morale: Just because some code is purely functional does not mean it is clear or correct.
odersky
added
the
fasttrack
smarter
previously requested changes
Jan 6, 2020
compiler/src/dotty/tools/dotc/reporting/diagnostic/messages.scala
Outdated
Show resolved
Hide resolved
anatoliykmetyuk
approved these changes
Jan 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation was very obscure and wrong on multiple counts