Skip to content

Add ekrich/sconfig to community-build #7855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2020
Merged

Add ekrich/sconfig to community-build #7855

merged 1 commit into from
Jan 7, 2020

Conversation

ekrich
Copy link
Contributor

@ekrich ekrich commented Dec 27, 2019

The module is from ekrich vs dotty-staging.

dottybot
dottybot reviewed Dec 27, 2019
View reviewed changes
Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

@SethTisue
Copy link
Member

I can vouch for Eric as a responsive and capable maintainer

also, sconfig is unusually Java-like code (translated line-by-line from Java), and that should be good for the diversity of the build

@anatoliykmetyuk anatoliykmetyuk self-assigned this Jan 6, 2020
@anatoliykmetyuk anatoliykmetyuk merged commit 947316d into scala:master Jan 7, 2020
@ekrich ekrich deleted the topic/comm-build-sconfig branch January 7, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dottybot dottybot dottybot left review comments

@anatoliykmetyuk anatoliykmetyuk anatoliykmetyuk approved these changes

Assignees

@anatoliykmetyuk anatoliykmetyuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ekrich @SethTisue @anatoliykmetyuk @dottybot