Ycheck that methods defined in ClassInfo exist in tree. #735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifies debugging for me.
Fixes bugs in handling try-finally blocks.
Includes fix to emission of invokeDynamic instructions in positions where expected type isn't the type of lambda being returned. SI-9387
Use x.length - y.length trick, Names are hash-consed.
Checks if the symbols is a synthetic symbol that is created by values class transformation to represent conversions between representations of a value class.
Mixi does not define stored&substed in classes that inherit this trait.
|
We now see a non-abstract method error for a lazy val in PatMat. |
used a wrong member function inside, led to errors similar to: java.lang.ClassFormatError: Duplicate method name&signature in class file dotty/tools/dotc/core/Types$WildcardType
They should not become deferred.
And there could be multiple symbols with same name in same scope, e.g.:
implicit class Foo(){}
will create implicit method Foo that and a lazy module named Foo
Making a correct fix could take some time, and I want to find other issues before I start working on this one.
|
With fixes from this branch, dotty compiled by dotty can print greeting without dying. |
|
What's the partest failure? Should we try to merge this or work on the branch separately |
|
The failure is due to incorrect check file added in this pr(extra line break). It should be fixed now. |
DarkDimius
force-pushed
the
ycheck-methods
branch
from
56c3c78 to
3377de5
Compare
|
@odersky tests passed, please review |
Added suggested changes by myself and @smarter.
|
LGTM for everything. |
odersky
added a commit
that referenced
this pull request
Aug 4, 2015
Ycheck that methods defined in ClassInfo exist in tree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #693.
Known to fail:
trait TreeInfo tree does not define methods: Set(method initial$MatchingArgs)