Create dotty-staging library #7080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
create-staging-lib
branch
14 times, most recently
from
4501e88 to
49645bd
Compare
nicolasstucki
force-pushed
the
create-staging-lib
branch
3 times, most recently
from
bbf73b8 to
9890305
Compare
smarter
requested changes
Aug 25, 2019
| import java.io.File.{ pathSeparator => sep } | ||
| val args = "-from-tasty" :: "-Yretain-trees" :: "-classpath" :: s"$classpath$sep$currentClasspath" :: classes | ||
| (new Consume).process(args.toArray) | ||
| } | ||
|
|
||
| private def getCurrentClasspath(cl: ClassLoader): String = { |
There was a problem hiding this comment.
Why does this need to be duplicated with QuoteDriver ? (Unrelated but this implementation looks very fragile to me, this makes way too many assumptions about how classloaders are setup, which might be broken by sbt 1.3 uses of layered classloaders for example)
There was a problem hiding this comment.
I will look into it in another PR. For now we keep the same behaviour as before.
nicolasstucki
force-pushed
the
create-staging-lib
branch
from
9890305 to
028615e
Compare
|
Rebased |
smarter
approved these changes
Aug 26, 2019
nicolasstucki
force-pushed
the
create-staging-lib
branch
2 times, most recently
from
a749162 to
0252bed
Compare
nicolasstucki
commented
Aug 27, 2019
| // when compiling a project that depends on dotty-staging (see ...), but we always need it to be present | ||
| // on the JVM classpath at runtime. | ||
| dependsOn(dottyCompiler(Bootstrapped) % "provided"). | ||
| dependsOn(dottyCompiler(Bootstrapped) % "compile->runtime"). |
There was a problem hiding this comment.
@smarter I had to separate the dependencies. % "provided,compile->runtime,test->test" was not working.
nicolasstucki
force-pushed
the
create-staging-lib
branch
from
0252bed to
fdec7ad
Compare
This was referenced Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract the staging out of the standard library and compiler.
dotty-stagingproject that depends ondotty-compilerdotty-stagingproject or jarScopeIdlogic intodotty.tools.dotc.quoted.QuoteContextlibrary/src-non-bootstrapped/scala/quoted/package.scalastaging.{run, withQuoteContext},Toolbox,QuoteDriver,QuoteCompiler,ExprCompilationUnittodotty-stagingToolbox.makedirectly (instead of as a java reflection call)"ch.epfl.lamp" %% "dotty-staging" % scalaVersion.value