Generate less code for lazy vals #706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rebuild |
Modules which are entirely synthetic now are eager This fix additionally makes inner objects of other objects remain static classes, instead of becoming lazy vals.
|
@odersky please review. |
|
|
||
| if (isField) { | ||
| if (sym.isVolatile || | ||
| (sym.is(Flags.Module) && !sym.is(Flags.Synthetic))) // companion class is synthesized. Should be threadsafe to |
There was a problem hiding this comment.
Did not understand comment. What does "companion class is synthesized" mean?
|
/rebuild |
|
@odersky review comments should be addressed now. |
|
LGTM |
DarkDimius
added a commit
that referenced
this pull request
Jul 20, 2015
Generate less code for lazy vals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes modules which are entirely synthetic be eager.
This fix additionally makes inner objects of other objects remain static classes, instead of becoming lazy vals.