-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Rename implied
to delegate
#6649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename implied
to delegate
#6649
Conversation
262f738
to
950d874
Compare
Fix example of type Nil.type
Huh -- this sort of comes out of left field. (I vaguely recall seeing it suggested on Contributors, but it hadn't seemed like one of the heavily-pushed options.) The docs don't appear to be in an experimental subdirectory as has been typical of these name changes: are you strongly considering this version? |
@jducoeur I am strongly considering the new version, mostly because, after thinking quite intensively about it, the I am now convinced we should be bolder. The feature merits having a simple name that can stand by itself. It must be a noun, analogous to After all the name wrangling here and on contributors I have come to the conclusion that there is no ideal pre-existing name for this feature. We have to create the name and establish it through usage. And
In the end, it will not matter, as long as it a noun that is easy to pronounce and expresses roughly what we intend it to mean. |
Okay, useful to know -- thanks! |
Delegate is also (and arguably more commonly) a verb. I suspect this might read to many users as an imperative command. |
@@ -28,7 +28,7 @@ object ImportInfo { | |||
* @param selectors The selector clauses | |||
* @param symNameOpt Optionally, the name of the import symbol. None for root imports. | |||
* Defined for all explicit imports from ident or select nodes. | |||
* @param importImplied true if this is an implied import | |||
* @param importImplied true if this is a delegate import |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
importImplied?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not have time to fix this yet. Right now only the surface is changed.
That's exactly how I interpreted the change in the Is there really no word that captures the intended meaning? I'm sure this has been rehashed over and over, but it seems |
I am not worried about the verb vs noun question, for two reasons:
delegate for Ord[Int] {
def (x: Int) < (y: Int) = ...
} If you want to read Both I have come to realize that there is no good pre-existing term for this, we just have to pick one which is not completely wrong and establish its meaning through usage. |
@odersky it works now, so you can merge it. I'll start the RC3 procedure once it is merged and passes CI on master. |
@anatoliykmetyuk I am on my way to the contributors summit. I want to raise the issue there for feedback before going ahead. |
So, it's merged. We needed to do it before my ScalaDays talk tomorrow, hence the urgency. But everything is still subject to change. Over the next months we will use all of Dotty's language features in our own code. That should give us good feedback, which might prompt some changes. |
Tomorrow morning 9:00 am 🎉🎉🎉 |
Please bring back "implied"! |
If you must insist on moving away from "implied", might I suggest "default" as a better alternative keyword? default IntOrd for Ord[Int] { |
Delegate means traditionally when one object delegates calls to another object. IMHO implied or implicit was much better. I like default as well. |
No description provided.