Add reflect API: Select.apply with a symbol #6615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
suggested changes
Jun 6, 2019
| @@ -282,6 +282,9 @@ class KernelImpl(val rootContext: core.Contexts.Context, val rootPosition: util. | |||
| if (self.symbol.signature == core.Signature.NotAMethod) None | |||
| else Some(self.symbol.signature) | |||
|
|
|||
| def Select_apply(qualifier: Term, symbol: Symbol)(implicit ctx: Context): Select = | |||
| withDefaultPos(implicit ctx => tpd.Select(qualifier, Types.TermRef(qualifier.tpe, symbol))) | |||
There was a problem hiding this comment.
This implicit function type will break the scala 2.12 build
There was a problem hiding this comment.
Which is only tested after the merge
There was a problem hiding this comment.
We already have it in the code above?
nicolasstucki
approved these changes
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add reflect API: Select.apply with a symbol
Note: it's still good to keep
Select.overloadedand generalize it to handle 0 and multiple param blocks. @OlivierBlanvillain has one use case for it AFAIK.