Java-compatible enums #6576

anatoliykmetyuk · 2019-05-28T13:00:43Z

No description provided.

odersky

Looks good overall. Needs just some minor changes.

compiler/src/dotty/tools/dotc/ast/DesugarEnums.scala

compiler/src/dotty/tools/dotc/transform/SyntheticMembers.scala

compiler/src/dotty/tools/backend/jvm/BackendInterface.scala

compiler/src/dotty/tools/dotc/ast/DesugarEnums.scala

compiler/src/dotty/tools/dotc/core/Definitions.scala

sjrd · 2019-06-07T05:22:08Z

I think there should be a test with a Scala-defined Java enum that is then used from a Java source file, exploiting some enum-specific features such as switching on them.

anatoliykmetyuk force-pushed the java-enums branch 2 times, most recently from c6e053a to b2a4898 Compare May 31, 2019 12:52

odersky mentioned this pull request Jun 3, 2019

Outstanding language changes #6572

Closed

6 tasks

anatoliykmetyuk force-pushed the java-enums branch 5 times, most recently from d2340a0 to f845ed7 Compare June 4, 2019 17:39

anatoliykmetyuk marked this pull request as ready for review June 4, 2019 18:04

anatoliykmetyuk requested a review from odersky June 4, 2019 18:04

anatoliykmetyuk force-pushed the java-enums branch 3 times, most recently from e1f7fdb to 5d5d108 Compare June 5, 2019 12:47

odersky requested changes Jun 5, 2019

View reviewed changes

anatoliykmetyuk mentioned this pull request Jun 6, 2019

Drop EnumValues from Enums' modules' API #6620

Closed

anatoliykmetyuk force-pushed the java-enums branch from 1cf8660 to 7e6869d Compare June 6, 2019 14:07

smarter reviewed Jun 6, 2019

View reviewed changes

compiler/src/dotty/tools/backend/jvm/BackendInterface.scala Outdated Show resolved Hide resolved

smarter reviewed Jun 6, 2019

View reviewed changes

compiler/src/dotty/tools/dotc/ast/DesugarEnums.scala Outdated Show resolved Hide resolved

smarter reviewed Jun 6, 2019

View reviewed changes

compiler/src/dotty/tools/dotc/core/Definitions.scala Outdated Show resolved Hide resolved

anatoliykmetyuk added 11 commits June 6, 2019 19:54

Define ordinal and name for enums

c9982ed

Module methods for enums implemented

2343830

Conform tests to the new Enums API

231b51f

Enums valuesOf exception type conforms to that of Java enums

56a76a5

Tests added for enum java compat API

023778c

Name removed from enum

702ced5

SyntheticMethods adapted to use ordinal instead of enumTag

2d7570c

Adapt CompleteJavaEnums to the new method names

35a20c9

SyntheticMethods' ordinal method calls the arg's ordinal method

c7a0149

method added to enums to carry the ordinal number unconditionally

78a2596

Synthetically generated oridnal method for enums

c44bf64

anatoliykmetyuk added 5 commits June 6, 2019 19:55

Fix documentation for

af652e9

Do not generate synthetic ordinal for Enum itself

86939eb

Fix enum-List-control test

1a42c3d

Stylistical improvements to the Enums code

33f6c77

Documentation fixes for enums

5aa8d91

anatoliykmetyuk force-pushed the java-enums branch from 9b65e33 to a8e76ac Compare June 6, 2019 18:19

anatoliykmetyuk added 4 commits June 6, 2019 20:23

Generate ACC_ENUM flags for Java enums

857549f

Make enums compatible with the new constructor hijack

9abfef8

Add tests for enums interop with Java efficient collections

79db9f7

Factor out derivesFromJavaEnum to SymUtils

0b4c546

anatoliykmetyuk force-pushed the java-enums branch from a8e76ac to 0b4c546 Compare June 6, 2019 18:24

odersky approved these changes Jun 6, 2019

View reviewed changes

odersky merged commit c46553a into scala:master Jun 6, 2019

anatoliykmetyuk deleted the java-enums branch June 6, 2019 22:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Java-compatible enums #6576

Java-compatible enums #6576

anatoliykmetyuk commented May 28, 2019

odersky left a comment

sjrd commented Jun 7, 2019

Java-compatible enums #6576

Java-compatible enums #6576

Conversation

anatoliykmetyuk commented May 28, 2019

odersky left a comment

Choose a reason for hiding this comment

sjrd commented Jun 7, 2019