Skip to content

Fix #3655: Remove hl interpolator #6471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 12, 2019
Merged

Fix #3655: Remove hl interpolator #6471

merged 4 commits into from
May 12, 2019

Conversation

OlivierBlanvillain
Copy link
Contributor

No description provided.

@OlivierBlanvillain OlivierBlanvillain requested a review from smarter May 7, 2019 12:36
OlivierBlanvillain
OlivierBlanvillain commented May 7, 2019
View reviewed changes
tests/neg/i2514.scala
@@ -1,10 +1,28 @@
object Foo {
def foo(): Int = {
val f: implicit Int => Int = (implicit x: Int) => 2 * x // error // error
val f: implicit Int => Int = (implicit x: Int) => 2 * x // error
Copy link
Contributor Author

@OlivierBlanvillain OlivierBlanvillain May 7, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is caused by the use of em instead of hl, which, IIUC, will shadow non nonsensically errors after the first one. On master this line has an additional error: // error: only classes can have declared but undefined members, I think keeping only the first one makes sense here.

smarter
smarter approved these changes May 7, 2019
View reviewed changes
@smarter
Copy link
Member

smarter commented May 7, 2019

Thanks for doing this!

allanrenucci
allanrenucci reviewed May 7, 2019
View reviewed changes
@OlivierBlanvillain
Copy link
Contributor Author

OlivierBlanvillain commented May 7, 2019 •
edited
Loading

I wonder if we should add color to the .show on symbols, or insert the hl highlighting by intercepting symbols in em. Now it seams like a regression:

(on master)
master

(on this PR)
this-pr

@smarter
Copy link
Member

smarter commented May 7, 2019

I wonder if we should add color to the .show on symbols,

Since calls to .show on other things already use colors I think that's reasonable.

@OlivierBlanvillain
Copy link
Contributor Author

I addressed the comments and added some colors to Symbol in RefinedPrinter, the last 3 commits need a review

@smarter smarter merged commit 0f8c950 into scala:master May 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanrenucci allanrenucci allanrenucci left review comments

@smarter smarter smarter approved these changes

Assignees

@smarter smarter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OlivierBlanvillain @smarter @allanrenucci