Fix #6385: Don't instantiate hk type constructors too early #6467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test performance please |
|
performance test scheduled: 5 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/6467/ to see the changes. Benchmarks is based on merging with master (b34ea5d) |
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/6467/ to see the changes. Benchmarks is based on merging with master (b34ea5d) |
Before searching for implicit arguments, if a the constraint contains a type parameter ``` P >: A <: B ``` where `P` occurs in the searched-for type and `A =:= B`, change the constraint to ``` P := B ``` instead. This improves the implicit search by making the searched-for type have fewer uninstantiated type variables.
The issue scala#6385 contains more explanations.
Avoid formation of full bounds.
In fact, the isLess relation is irrelevant here. If p >: L <: H and L =:= H and the constraint is satisfiable, then it's safe to replace p by L or H anyway, no matter what other parameters are known to be smaller or larger than p.
18ce5d2 fixed it.
griggt
added a commit
to griggt/dotty
that referenced
this pull request
Oct 22, 2020
Fixed by 18ce5d2 in scala#6467
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue #6385 contains more explanations.