Fix #6419: Support @compileTimeOnly #6424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-#6419
branch
3 times, most recently
from
ae35b5e to
4b3d0c1
Compare
liufengyun
reviewed
May 2, 2019
| } | ||
| case _ => // OK | ||
| } | ||
| } |
There was a problem hiding this comment.
In RefChecks.scala, there is commented code:
/* (Not enabled yet)
* See an explanation of compileTimeOnly in its scaladoc at scala.annotation.compileTimeOnly.
*
if (sym.isCompileTimeOnly) {
def defaultMsg =
sm"""Reference to ${sym.fullLocationString} should not have survived past type checking,
|it should have been processed and eliminated during expansion of an enclosing macro."""
// The getOrElse part should never happen, it's just here as a backstop.
ctx.error(sym.compileTimeOnlyMessage getOrElse defaultMsg, pos)
}*/Maybe we should just revive the code?
There was a problem hiding this comment.
No, it would not take into account if it is into an erased context or not. Which is already performed in the place where I check it.
There was a problem hiding this comment.
As in https://github.com/lampepfl/dotty/pull/6424/files#diff-a12cb93e6ac05566103dd86ede6e5901R12, where the reference of the @compileTimeOnly is inside an erased def
nicolasstucki
force-pushed
the
fix-#6419
branch
4 times, most recently
from
193da2e to
d530970
Compare
liufengyun
approved these changes
May 3, 2019
There was a problem hiding this comment.
Need to drop scalatest changes and rebase over #6444.
Otherwise, LGTM
Caught by @compileTimeOnly
|
Dropped scalatest changes and rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support @compileTimeOnly and remove migration waining (see #6419 (comment)).