Post typer transformer #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs new TypeRef creation method that works for NoPrefix and at the same time does not need a denotation. This is provided by method TermRef.withNakedSymbol.
| /** A trait that's assumed by the transformers that run right after typer. | ||
| * Ensures that trees are normalized when seen by other transforms. This means: | ||
| * (1) All module class definitions appear after their companion class definitions | ||
| * (2) There are no import clauses or named arguments |
There was a problem hiding this comment.
Just to reduce variety of types of trees which can be seen during transformations.
This is performed after the "Frontend" phase, so IDEs and, possibly, quasiquotes, should be able to see NamedArgs and Imports.
1) reorders companion objects so that they allways follow matching classes 2) removes imports and named arguments 3) rewrites all trees holding types are to TypeTrees
Added a prepareForStats&transformStats pair of methods, which provide a convinient way to alter scopes of PackageDefs, Templates and Block's.
A transformer that provides a convenient way to create companion objects.
|
LGTM now. |
|
LGTM |
Closed
This was referenced Mar 16, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transformer that simplifies life of Transforms by: