Avoid forcing lambda parameter types in overloading resolution #6132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test performance please |
1 similar comment
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/6132/ to see the changes. Benchmarks is based on merging with master (bb0a1ed) |
odersky
force-pushed
the
change-overload-lambda
branch
from
3257173 to
c6a561c
Compare
When taking the `typedArgs` of a `FunProto` we now always avoid failing on untyped parameters of lambdas. Instead we give the parameter a ? type and continue. This allows to use lambdas with untyped parameters in more situations than before.
With the new context merging technique it's no longer needed. We now propagate any updates to the context from a FuncProto.typedArg immediately into the caller context. So no need to check later whether the update is present.
odersky
force-pushed
the
change-overload-lambda
branch
from
ccc064c to
cd9e7e1
Compare
|
test performance please |
|
performance test scheduled: 2 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/6132/ to see the changes. Benchmarks is based on merging with master (eecd672) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When taking the
typedArgsof aFunProtowe now always avoid failingon untyped parameters of lambdas. Instead we give the parameter a ? type
and continue.
This allows to use lambdas with untyped parameters in more situations
than before.