Skip to content

Drop AndTypeTree and OrTypeTree #5935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Feb 18, 2019
Merged

Drop AndTypeTree and OrTypeTree #5935

merged 14 commits into from
Feb 18, 2019

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Feb 16, 2019 •
edited
Loading

Drop special treatement and AndTypeTree and OrTypeTree. Replace with regular InfixOp/AppliedTypeTree nodes.

@odersky odersky changed the title Check for illegal wildcards in TypeAssigner Drop AndTypeTree and OrTypeTree Feb 16, 2019
@odersky odersky added stat:wip and removed stat:wip labels Feb 16, 2019
@odersky odersky force-pushed the drop-andor-typetree branch from d6ff493 to 6ba9bc7 Compare February 17, 2019 15:03
@odersky
Copy link
Contributor Author

odersky commented Feb 17, 2019

Quite an impressive savings in LOC. Also fixes some holes where illegal wildcard types went undetected.

@nicolasstucki
Copy link
Contributor

test performance please

@dottybot
Copy link
Member

performance test scheduled: 1 job(s) in queue, 1 running.

@dottybot
Copy link
Member

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/5935/ to see the changes.

Benchmarks is based on merging with master (2b0e4a1)

@nicolasstucki
Copy link
Contributor

tests/run/tasty-extractors-2 should not be disabled. Now we have testCompilation --update-checkfiles tests/run/tasty-extractors-2 to update the check file.

odersky added 10 commits February 18, 2019 12:05
@odersky
Check for illegal wildcards in TypeAssigner
a4b1709 
Drop previous checking in Parser. The idea is that the parser should
follow the syntax. Checking conditions that are not reflected in the
syntax should come later.
@odersky
Refinements to wildcard checking
a8afd92 
Simplify and cover cases that were missing (see gadt-GadtStatic.scala).
@odersky
Fix test
a102921 
Another test slipped through. It seems using `_` for "inferred argument"
is quite popular, even though it's not supported by the language.
@odersky
Drop OrTypeTree
e4bd16f
@odersky
Drop AndTypeTree
4772b86
@odersky
Disable tasty-extractors-2 test
2499e0e 
I believe the test is counter-productive. It leads to ossification by
pedantically insisting on the status quo. If we want to test tasty extractors
we need to find a way that tests it so that we can still change constrructors
and extractors.
@odersky
Fix typo
7306b74
@odersky
Fix syntax highlighting test
f47e895
@odersky
Drop mayBeTypePat
b9b9388 
It does not seem to serve a purpose. The only test where it was used does
not really make sense.
@odersky
Bump Tasty version
b902306
@odersky odersky force-pushed the drop-andor-typetree branch from 6ba9bc7 to b902306 Compare February 18, 2019 11:41
@odersky
Copy link
Contributor Author

odersky commented Feb 18, 2019

@nicolasstucki Can you finish this PR? We still need to re-enable the tasty-extractor test and there are two issues open in the Tasty reflect framework 9see my comments above).

@odersky odersky assigned nicolasstucki and unassigned odersky Feb 18, 2019
@nicolasstucki
Copy link
Contributor

@odersky I made the changes. You should have a quick look at my commits.

@odersky
Copy link
Contributor Author

odersky commented Feb 18, 2019

@nicolasstucki Your changes LGTM

@odersky odersky merged commit 4141bd2 into scala:master Feb 18, 2019
@allanrenucci allanrenucci deleted the drop-andor-typetree branch February 18, 2019 21:48
@smarter smarter mentioned this pull request Dec 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasstucki nicolasstucki nicolasstucki approved these changes

Assignees

@odersky odersky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@odersky @nicolasstucki @dottybot