Fix #5794: eta-expansion triggered properly #5795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
approved these changes
Jan 25, 2019
|
To make the git history easier to follow, please squash these two commits in one commit, and add the description in #5795 (comment) to the commit message. |
Previously eta-expansion was not triggered because the refined type-ness wasn't taken under-consideration in two places. - `functionArity` was prohibiting the necessary branch to be taken: solved after dropping the refinement - `isNonDepFunctionType` wasn't checking whether the prototype was a refined type (also renamed method)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously eta-expansion was not triggered because the refined type-ness wasn't taken under-consideration in two places.
functionAritywas prohibiting the necessary branch to be taken: solved after dropping the refinementisNonDepFunctionTypewasn't checking whether the prototype was a refined type (also renamed method)