Skip to content

Fix #4985: Generate productElementName for case classes #5617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2018
Merged

Fix #4985: Generate productElementName for case classes #5617

merged 1 commit into from
Dec 15, 2018

Conversation

tOverney
Copy link
Contributor

No description provided.

dottybot
dottybot reviewed Dec 15, 2018
View reviewed changes
Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

@tOverney tOverney force-pushed the productName branch 2 times, most recently from 68256f6 to d3d4198 Compare December 15, 2018 15:35
@tOverney
Copy link
Contributor Author

tOverney commented Dec 15, 2018 •
edited
Loading

Note: productElementName and productElementNames are not yet on Product.scala (added in Scala 2.13.x) hence why overriding tests are currently commented out.

When the Scala Library is updated to 2.13.x, there will be need to uncomment the test and add the override keyword to the generated method for case classes.

allanrenucci
allanrenucci reviewed Dec 15, 2018
View reviewed changes
Copy link
Contributor

@allanrenucci allanrenucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, looks good!

allanrenucci
allanrenucci approved these changes Dec 15, 2018
View reviewed changes
Copy link
Contributor

@allanrenucci allanrenucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@allanrenucci allanrenucci merged commit fcc35d2 into scala:master Dec 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjrd sjrd sjrd left review comments

@dottybot dottybot dottybot left review comments

@allanrenucci allanrenucci allanrenucci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tOverney @sjrd @allanrenucci @dottybot