Skip to content

Fix quote positions (missing Inlined nodes) #5505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 12, 2018

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Nov 23, 2018

Follow up of #5048
Based on #5510

@nicolasstucki nicolasstucki self-assigned this Nov 23, 2018
@nicolasstucki nicolasstucki force-pushed the fix-quote-positions branch 5 times, most recently from 4550883 to 915c95b Compare November 24, 2018 07:30
@nicolasstucki nicolasstucki force-pushed the fix-quote-positions branch 6 times, most recently from 5976706 to 8fa5f98 Compare November 26, 2018 09:51
@nicolasstucki nicolasstucki force-pushed the fix-quote-positions branch 4 times, most recently from f946065 to cc17c4e Compare December 6, 2018 13:59
@nicolasstucki nicolasstucki force-pushed the fix-quote-positions branch 2 times, most recently from 4c19c53 to 008756a Compare December 6, 2018 15:42
@nicolasstucki nicolasstucki force-pushed the fix-quote-positions branch 2 times, most recently from 3ab4ec4 to cd44ef2 Compare December 7, 2018 14:08
@nicolasstucki nicolasstucki added this to the 0.12 Tech Preview milestone Dec 7, 2018
Copy link
Contributor

@Blaisorblade Blaisorblade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (with a couple of comments @nicolasstucki is adding).

@nicolasstucki nicolasstucki merged commit 2b95357 into scala:master Dec 12, 2018
@nicolasstucki nicolasstucki deleted the fix-quote-positions branch December 12, 2018 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants